Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update txnbuild to support stellar-core v12 (part 1 or 2) #1771

Closed
5 tasks
ire-and-curses opened this issue Sep 23, 2019 · 1 comment
Closed
5 tasks

Update txnbuild to support stellar-core v12 (part 1 or 2) #1771

ire-and-curses opened this issue Sep 23, 2019 · 1 comment
Assignees
@bartekn
Labels
txnbuild 2nd-generation transaction build library for Go SDK

Comments

@ire-and-curses
Copy link
Member

Before v12 vote:

  • Add deprecation warning to txnbuild to indicate that the existing PathPayment operation will be renamed to PathPaymentStrictReceive in a few weeks' time
  • Add new operation PathPaymentStrictReceive to SDK, duplicating existing PathPayment operation. Programmers can begin moving client calls immediately
  • Raise corresponding build issues for other SDKs (including JS and Java)
  • Update Godoc and examples
  • Release

This is part of #1737.
@ire-and-curses ire-and-curses added the txnbuild 2nd-generation transaction build library for Go SDK label Sep 23, 2019
@ire-and-curses ire-and-curses added this to the Horizon 0.22.0 milestone Sep 23, 2019
This was referenced Sep 23, 2019
Closed
Closed
Closed
This was referenced Sep 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@bartekn bartekn self-assigned this Sep 24, 2019
@bartekn bartekn mentioned this issue Sep 24, 2019
Closed
1 task
@bartekn
Copy link
Contributor

bartekn commented Sep 26, 2019

Partially closed in #1776. We still need to add deprecation warnings and check if godoc looks good.

@rice2000 rice2000 mentioned this issue Oct 3, 2019
Closed
@bartekn bartekn removed this from the Horizon 0.23.0 milestone Oct 14, 2019
@bartekn bartekn closed this as completed Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartekn bartekn

Labels
txnbuild 2nd-generation transaction build library for Go SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bartekn @ire-and-curses