Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stellar-core protocol 12 #64

Closed
rice2000 opened this issue Oct 3, 2019 · 2 comments
Closed

Support stellar-core protocol 12 #64

rice2000 opened this issue Oct 3, 2019 · 2 comments

Comments

@rice2000
Copy link

rice2000 commented Oct 3, 2019

The upcoming stellar-core protocol 12 release will add support for CAP 24 ("Make PathPayment Symmetrical").

To support this change, the following steps are necessary:

  • Existing PathPayment operation should be deprecated (it will be renamed to PathPaymentStrictReceive in protocol 12, with behavior unchanged). Consider adding the new operation name immediately as an alias during the transition period.
  • Once v12 is voted on and is adopted by the network, a new operation, PathPaymentStrictSend will be available and should be provided. This is expected to happen around the end of October, 2019.
  • Horizon will continue to provide the old path_payment operation name in responses until Horizon 0.24. Both types of path_payment operation will be returned with the existing name. In Horizon release 0.24 (targeted for ~10 weeks from now, Horizon will change, and begin to return path_payment_strict_receive and path_payment_strict_send in the type field of responses that refer to operations or payments. You should update client code if necessary (e.g. for validation) and note this for users.

For further information, see the following issues in the SDF Go monorepo:

@ire-and-curses
Copy link
Collaborator

I believe this is now implemented in astroband/ruby-stellar-base#51 and released in https://github.com/bloom-solutions/ruby-stellar-base/releases/tag/v0.21.0. It would be nice to have release notes for future reference @ramontayag.

@JakeUrban
Copy link
Contributor

Closing this issue since Adolfo already implemented it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants