Make horizonclient examples fully qualified #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
approved these changes
Oct 22, 2019
There was a problem hiding this comment.
Thanks! Looks good to me! However, I'm deferring to @leighmcculloch and @ire-and-curses for an extra pair of 👁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've moved all the
Example*functions from the various horizonclient tests into a singleexamples_test.gofile and named the packagehorizonclient_test. This means thehorizonclientpackage must be explicitly imported, making the examples fully qualified and easier to use.I've created a commit per individual file that was updated and aside from resolving the compiler errors made no other code changes. The final commit has some minor formatting changes. I can split it up in separate PR's if preferred in case that's easier to review.
Fixes #1660