all: run go generate during ci builds to check all files updated #2372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Run
go generate
during ci builds.Why
We use
go generate
to trigger builds of our bindata files for SQLmigrations but we don't have any broad checks on CI that ensure that the
generated files are up to date. This ensures whenever we make a change
to an input file to code generation that the generated file is updated
in the same change/pull-request.
We achieve this to some degree in some apps, like Horizon, where we have
a test that checks that the generated data bytes match the bytes on
disk, but this is only in one app, requires us to write a test in each
app, and doesn't prevent diffs caused by environmental changes like us
upgrading the version of the go-bindata tool.
Known limitations
[TODO or N/A]