services/horizon: Add Muxed Account details to effect responses #3610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
force-pushed
the
3591-add-muxed-details-to-effects
branch
from
b0be928
to
0399bd5
Compare
Shaptic
reviewed
May 20, 2021
2opremio
force-pushed
the
3591-add-muxed-details-to-effects
branch
2 times, most recently
from
ba9bec4
to
a623765
Compare
1 task
bartekn
approved these changes
May 21, 2021
| // We abuse the details to inject muxed-account information without changing the DB schema | ||
| details["account_muxed"] = address.Address() | ||
| details["account_muxed_id"] = uint64(address.Med25519.Id) | ||
| } |
There was a problem hiding this comment.
Sorry, this might have been discussed in previous PR but why not add a new column to the table? Adding a DEFAULT NULL column is fast as far as I can remember.
There was a problem hiding this comment.
I discarded that because I agreed with @ire-and-curses to minimize schema changes.
That said, if we agree to make a schema change, it would also solve the performance problem with #3619
There was a problem hiding this comment.
ok, let's add the column. I don't like having to deserialise the whole envelope every time. Lesser of two evils.
There was a problem hiding this comment.
OK, I will merge this as is and then change the approach.
2opremio
force-pushed
the
3591-add-muxed-details-to-effects
branch
from
a623765
to
6bd8790
Compare
tamirms
approved these changes
May 21, 2021
2opremio
force-pushed
the
3591-add-muxed-details-to-effects
branch
from
6bd8790
to
43c2435
Compare
This was referenced Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #3591
Depends on #3603 (whose commits are included here for now)
TODO: