Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Add muxed account details to transactions and change schema #3626

Merged

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented May 24, 2021

Addresses part of #3591

It:

  • Adds muxed account details to transactions (account source and fee account source)
  • Adds new DB table columns for muxed accounts. This changes the approach used for effects and operations, for which we previously abused the details field to include the muxed account information.
  • Adds an integration test to make sure the new Muxed Account details work end-to-end.

TODO: add an integration test (which is currently WIP and will come shortly in a separate PR).

@2opremio 2opremio requested a review from a team May 24, 2021 17:19
@2opremio 2opremio force-pushed the 3591-add-trasaction-details-and-change-schema branch from aa265ba to 5a458eb Compare May 25, 2021 10:41
@2opremio 2opremio force-pushed the 3591-add-trasaction-details-and-change-schema branch 2 times, most recently from 79bd8c4 to f56abcf Compare May 25, 2021 11:28
@2opremio 2opremio force-pushed the 3591-add-trasaction-details-and-change-schema branch from f56abcf to 28b0989 Compare May 25, 2021 12:02
@2opremio 2opremio merged commit a81cea3 into stellar:master May 25, 2021
@2opremio 2opremio deleted the 3591-add-trasaction-details-and-change-schema branch May 25, 2021 12:19
This was referenced Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants