services/horizon: Fix data races found by integration tests #3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
approved these changes
Jun 15, 2021
2opremio
reviewed
Jun 15, 2021
clients/horizonclient/client.go
Outdated
| @@ -26,8 +26,8 @@ import ( | |||
|
|
|||
| // sendRequest builds the URL for the given horizon request and sends the url to a horizon server | |||
| func (c *Client) sendRequest(hr HorizonRequest, resp interface{}) (err error) { | |||
| c.HorizonURL = c.fixHorizonURL() | |||
| req, err := hr.HTTPRequest(c.HorizonURL) | |||
| horizonURL := c.fixHorizonURL() | |||
There was a problem hiding this comment.
I think a comment is in order here
There was a problem hiding this comment.
I think we'll need to update the horizonclient release notes as well
tamirms
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
This commit adds
-raceflag to Horizon integration tests and fixes two bugs found by race detector:Client.sendRequestoverwritingc.HorizonURLwhen used in multiple go routines.decoder.IgnoreUnknownKeysoverwritinggorilla/schema.Decoder.ignoreUnknownKeyswhen called from multiple go routines.