Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest: Properly parse and emit debug-level tags from Captive Core. #3746

Merged
merged 3 commits into from
Jul 7, 2021

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Jul 6, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Logs better in cases where the line can't be parsed, and properly parses debug-level logs, as well.

Why

Logs that are marked with DEBUG were treated as un-parseable by the Captive Core runner, which incorrectly truncated the log category. Closes #3692.

@Shaptic Shaptic added the bug label Jul 6, 2021
@Shaptic Shaptic requested a review from a team July 6, 2021 23:07
@Shaptic Shaptic self-assigned this Jul 6, 2021
@Shaptic Shaptic merged commit 1ee7c27 into stellar:master Jul 7, 2021
@Shaptic Shaptic deleted the logging-fix branch July 7, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Captive core logs are missing information and have the wrong log level
2 participants