Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streaming heartbeat support to Horizon #379

Merged
merged 6 commits into from
Mar 28, 2018
Merged

Add streaming heartbeat support to Horizon #379

merged 6 commits into from
Mar 28, 2018

Conversation

nullstyle
Copy link
Contributor

Closes #376 by adding a 5 second heartbeat to SSE connections.

// heartbeatEvent represents a comment line that can be sent to the client to keep a long lived
// connection alive.
var heartbeatEvent = Event{
Comment: "bu-bump",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@nullstyle nullstyle merged commit d478595 into master Mar 28, 2018
@nullstyle nullstyle deleted the fix-376 branch March 28, 2018 15:49
@bartekn bartekn mentioned this pull request May 14, 2018
bartekn added a commit that referenced this pull request May 17, 2018
This reverts commit d478595, reversing
changes made to e55d602.
nullstyle pushed a commit that referenced this pull request May 23, 2018
This reverts commit d478595, reversing
changes made to e55d602.
nullstyle added a commit that referenced this pull request Jul 31, 2018
This reverts commit d478595, reversing
changes made to e55d602.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants