Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdr: Add AbsBeforeEpoch to ClaimableBalance:Predicate API resource #4148

Merged
merged 9 commits into from
Dec 20, 2021

Conversation

sreuland
Copy link
Contributor

@sreuland sreuland commented Dec 17, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

added a new optional field AbsBeforeEpoch to the API resource ClaimableBalance:Predicate, it is the Unix Epoch value represented by the same custom extended ISO date value in the AbsBefore field.

Why

this extra info for Epoch will enable SDK's to use the epoch for absolute before value of claimable balance predicate rather than attempt to parse the ISO, which gets complicated when the date very large, beyond the ISO standard range of year 9999. Some SDK's like the java SDK have bug fix pending on this change, like Java SDK #354

Closes #4095

Known limitations

@sreuland sreuland requested a review from a team December 17, 2021 20:20
xdr/json.go Outdated Show resolved Hide resolved
xdr/json.go Outdated Show resolved Hide resolved
xdr/json.go Outdated Show resolved Hide resolved
Copy link

@eliane345 eliane345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desculpe por transtornos causados

Copy link

@eliane345 eliane345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desculpe o incômodo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: API - Add original integral value for ClaimableBalance:Claimant:Predicate:AbsBefore
4 participants