Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Skip state verification on GetExpStateInvalid error #4523

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Aug 9, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Return from maybeVerifyState when GetExpStateInvalid returns an error.

Why

stateInvalid may be incorrect in such case.

Known limitations

[TODO or N/A]

@bartekn bartekn requested a review from a team August 9, 2022 07:44
@bartekn bartekn changed the title services/horizon/ingest: Skip state verification on GetExpStateInvali… services/horizon: Skip state verification on GetExpStateInvalid error Aug 9, 2022
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think there's any worthwhile change on coverage in the unit test that hits this method to assert this outcome, I was looking at https://github.com/bartekn/go/blob/skip-state-verify-when-error/services/horizon/internal/ingest/main_test.go#L183

@bartekn
Copy link
Contributor Author

bartekn commented Aug 10, 2022

@sreuland good call! I improved the test in 4a9f86d.

@bartekn bartekn force-pushed the skip-state-verify-when-error branch from 41f3ca0 to 4a9f86d Compare August 10, 2022 08:43
@bartekn bartekn merged commit 6ecfa3f into stellar:master Aug 10, 2022
@bartekn bartekn deleted the skip-state-verify-when-error branch August 10, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants