Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingestion fastbatch cbp #5085

Closed
wants to merge 7 commits into from
Closed

Ingestion fastbatch cbp #5085

wants to merge 7 commits into from

Conversation

urvisavla
Copy link
Contributor

@urvisavla urvisavla commented Oct 19, 2023 •
edited

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Use FastBatchInsertBuilder for writing to claimable_balances and claimable_balance_claimants tables. FastBatchInsertBuilder uses ‘COPY' to insert into the db which is faster than using 'INSERT'.

Why

#5086

Known limitations

@urvisavla urvisavla added horizon ingest New ingestion system WIP Work in progress labels Oct 19, 2023
@urvisavla urvisavla force-pushed the ingestion-fastbatch-cbp branch 3 times, most recently from 30ac939 to 9ce82de Compare October 20, 2023 06:56
@urvisavla urvisavla mentioned this pull request Oct 20, 2023
Closed
@urvisavla urvisavla added the performance issues aimed at improving performance label Oct 20, 2023
tamirms and others added 7 commits October 24, 2023 15:06
@tamirms @Shaptic @urvisavla
support/db: Add batch insert builder which uses COPY to insert rows (s…
3789046 
…tellar#4916)

* Add batch insert builder which uses COPY to insert rows

* Update support/db/fast_batch_insert_builder.go

Co-authored-by: George <Shaptic@users.noreply.github.com>

* Update fast_batch_insert_builder_test.go

---------

Co-authored-by: George <Shaptic@users.noreply.github.com>
@urvisavla
Fix FastBatchInsertBuilder test
a5904d0
@urvisavla
Use FastBatchInsertBuilder to insert to insert into claimable_balance…
4a1075d 
…s and claimable_balance_claimants tables
@urvisavla
Fix formatting
fdc4d80
@urvisavla
Convert byte[] to string to bypass encoding
29eb9cd
@urvisavla
Add a comment
dbbf206
@mollykarcher @urvisavla
Merge pull request stellar#5060 from tamirms/fix-payments-query
b797454 
services/horizon/internal/db2/history: fix payments query

(cherry picked from commit 4391e0b)
@sreuland
Copy link
Contributor

@urvisavla , per the branching strategy discussion, you intend to change merge target on this PR to ingestion-next? Wanted to let you know, I have two changes headed into the branch soon:

after which, if you then merge this PR to ingestion-next, we can then take the branch into some performance testing cycles to see how it's looking with all in, does this sound ok?

@urvisavla
Copy link
Contributor Author

urvisavla commented Oct 26, 2023 •
edited

@urvisavla , per the branching strategy discussion, you intend to change merge target on this PR to ingestion-next? Wanted to let you know, I have two changes headed into the branch soon:

after which, if you then merge this PR to ingestion-next, we can then take the branch into some performance testing cycles to see how it's looking with all in, does this sound ok?

Thanks @sreuland. Yes, as discussed, I am waiting for #5083 to be merged before I rebase and send this PR for review. I have started reviewing the #5083 and have a few questions that we can discuss tomorrow.

Also, I can port the latest master to ingestion-next branch if you have not already started.

@urvisavla urvisavla removed horizon ingest New ingestion system performance issues aimed at improving performance labels Oct 31, 2023
@urvisavla urvisavla closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
WIP Work in progress
Projects
Platform Scrum
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urvisavla @sreuland @tamirms @mollykarcher