services/horizon/ingest: removed legacy core cursor update against during ledger ingestion #5158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion and unused core db related config flags
sreuland
commented
Jan 11, 2024
| @@ -273,13 +272,6 @@ func NewSystem(config Config) (System, error) { | |||
| cancel() | |||
| return nil, errors.Wrap(err, "error creating captive core backend") | |||
| } | |||
| } else { | |||
There was a problem hiding this comment.
this was unreachable code, config.RemoteCaptiveCoreEnabled() is the inverse of config.LocalCaptiveCoreEnabled(), horizon assumes only captive core.
urvisavla
reviewed
Jan 11, 2024
sreuland
added a commit
to sreuland/go
that referenced
this pull request
Jan 29, 2024
…ring ledger ingestion (stellar#5158)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Removed the core cursor update that is attempted by ingest fsm on each ledger, as it was only relevant to legacy core db ingestion which is no longer enabled, only captive core ingestion.
Removed the configuration flags
--stellar-core-url-db,--cursor-name--skip-cursor-update, as they are related to legacy core db ingestion which is no longer usable.if one of the aforementioned flags is present, horizon will exit and report the error on console
Closes #5153
Why
discovered the un-necessary core cursor update taking time during performance benchmarking.
Known limitations