Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http archive requests include user agent and metrics #5166

Merged
merged 6 commits into from Jan 18, 2024

Conversation

sreuland
Copy link
Contributor

@sreuland sreuland commented Jan 17, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

fixed the history archive config for http backend to include custom user-agent value.
added history_archive_stats_total metrics for counters on requests and downloads of files from Archive, most of changes in the pr are related to enabling the metrics.

Why

visibility on how much the archives are being used by horizon ingestion.
Closes #5161

Known limitations

this is targeting the 2.28.0 release branch, it will be ported to master as part of porting the final release back to master later.

@sreuland sreuland requested a review from Shaptic January 17, 2024 20:25
@sreuland sreuland merged commit 3483910 into stellar:release-horizon-v2.28.0 Jan 18, 2024
28 checks passed
sreuland added a commit to sreuland/go that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants