Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go version to 1.22 #5232

Merged

Conversation

urvisavla
Copy link
Contributor

@urvisavla urvisavla commented Mar 4, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Bump go version to 1.22

Why

#5230

Known limitations

N/A

@urvisavla urvisavla marked this pull request as ready for review March 5, 2024 19:39
@sreuland
Copy link
Contributor

sreuland commented Mar 6, 2024

@urvisavla , can you target this pr at new 2.28.4 rel branch, thanks!

@urvisavla
Copy link
Contributor Author

@urvisavla , can you target this pr at new 2.28.4 rel branch, thanks!

Sure if we're planning to get 2.28.4 out in a day or two; otherwise it might be better to include this in 2.28.3 considering it's related to a CVE?

@urvisavla urvisavla changed the base branch from release-horizon-v2.28.3 to release-horizon-v2.28.4 March 6, 2024 22:26
@urvisavla urvisavla merged commit 39482cc into stellar:release-horizon-v2.28.4 Mar 6, 2024
28 checks passed
@urvisavla urvisavla deleted the bump-go-version-1.22 branch March 6, 2024 22:43
sreuland pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: tamirms <tamirms@gmail.com>
Shaptic pushed a commit to Shaptic/go that referenced this pull request Mar 12, 2024
Co-authored-by: tamirms <tamirms@gmail.com>
Shaptic pushed a commit to Shaptic/go that referenced this pull request Mar 12, 2024
Co-authored-by: tamirms <tamirms@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants