Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/httpx: Add prometheus metrics for requests in flight and requests received #5240

Merged
merged 2 commits into from Mar 11, 2024

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Mar 11, 2024

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Add prometheus metrics for requests in flight and requests received.

Why

We already have metrics for requests served but we don't have any metrics for requests received or requests in flight. Having these metrics will allow us to detect cases where there are a large amount of requests building up in horizon. This would also be helpful in debugging cases where there is a spike in TCP connections.

Known limitations

[N/A]

@tamirms tamirms requested a review from a team March 11, 2024 08:36
@tamirms tamirms merged commit 6fe5270 into stellar:master Mar 11, 2024
29 checks passed
@tamirms tamirms deleted the request-metrics branch March 11, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants