Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release w/ support for stable Protocol 20 and RPC. #167

Merged
merged 12 commits into from
Dec 6, 2023
Merged

Prepare release w/ support for stable Protocol 20 and RPC. #167

merged 12 commits into from
Dec 6, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Oct 24, 2023 •
edited
Loading

This is a staging ground for all of the changes necessary to get an SDK compatible with the upcoming stable release of Protocol 20. This PR is a conglomeration of PRs that have already been approved:

Note that this work will also need to be ported to the stellar-sdk.

@socket-security
Copy link

socket-security bot commented Oct 24, 2023 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
prettier 3.1.0 filesystem, environment +0 8.44 MB prettier-bot
eslint-config-prettier 9.0.0...9.1.0 None +5/-5 3.81 MB lydell
@types/urijs 1.19.22...1.19.25 None +0/-0 15.6 kB types
@babel/preset-typescript 7.23.2...7.23.3 None +21/-21 9.77 MB nicolo-ribaudo
@types/mocha 10.0.3...10.0.6 None +0/-0 95.6 kB types
@babel/cli 7.23.0...7.23.4 None +16/-16 9.48 MB nicolo-ribaudo
@types/chai 4.3.9...4.3.11 None +0/-0 76.8 kB types
@babel/preset-env 7.23.2...7.23.5 None +71/-70 11.6 MB nicolo-ribaudo
@babel/core 7.23.2...7.23.5 None +15/-15 9.37 MB nicolo-ribaudo
@typescript-eslint/parser 6.9.1...6.13.2 None +11/-11 37.3 MB jameshenry
@types/node 20.8.10...20.10.3 None +0/-0 3.93 MB types
@babel/eslint-plugin 7.22.10...7.23.5 None +22/-22 13.3 MB nicolo-ribaudo
lint-staged 14.0.1...15.2.0 None +18/-12 1.84 MB okonet
eslint 8.52.0...8.55.0 None +4/-4 3.78 MB eslintbot
axios 1.6.0...1.6.2 None +0/-0 1.8 MB jasonsaayman
@babel/eslint-parser 7.22.15...7.23.3 None +21/-21 13.3 MB nicolo-ribaudo
typescript 5.2.2...5.3.2 None +0/-0 32 MB typescript-bot
@definitelytyped/dtslint 0.0.189...0.0.197 None +32/-32 45.1 MB definitelytyped-publisher

🚮 Removed packages: stellar-base@10.0.0-beta.4

@Shaptic Shaptic changed the title [Draft] Upgrade library to work with stable XDR [Draft] Upgrade library to work with stable XDR and RPC Oct 26, 2023
@Shaptic Shaptic mentioned this pull request Oct 27, 2023
Merged
3 tasks
@Shaptic Shaptic added this to the Soroban Stable P20 Release milestone Oct 31, 2023
@Shaptic Shaptic self-assigned this Oct 31, 2023
This was referenced Oct 31, 2023
Closed
Closed
@Shaptic Shaptic changed the title [Draft] Upgrade library to work with stable XDR and RPC [Draft] Release v1.0.0-rc.1 w/ support for stable Protocol 20 and RPC. Nov 30, 2023
@Shaptic Shaptic force-pushed the stable branch 2 times, most recently from bea200c to ae26bef Compare November 30, 2023 22:10
Shaptic added a commit to stellar/js-stellar-sdk that referenced this pull request Dec 1, 2023
@Shaptic
Add all changes matching stellar/js-soroban-client#167
d75e3a6
@Shaptic Shaptic mentioned this pull request Dec 1, 2023
Merged
4 tasks
@Shaptic Shaptic changed the title [Draft] Release v1.0.0-rc.1 w/ support for stable Protocol 20 and RPC. Release v1.0.0-rc.1 w/ support for stable Protocol 20 and RPC. Dec 5, 2023
@Shaptic Shaptic requested review from sreuland and stellarsaur and removed request for sreuland December 5, 2023 17:09
@Shaptic Shaptic marked this pull request as ready for review December 5, 2023 17:52
@Shaptic Shaptic changed the title Release v1.0.0-rc.1 w/ support for stable Protocol 20 and RPC. Prepare release w/ support for stable Protocol 20 and RPC. Dec 5, 2023
sreuland
sreuland approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, since changing system-test to use js-stellar-sdk, unfortunately won't have e2e coverage on this lib anymore, but is deprecated.

@Shaptic Shaptic merged commit 4caf267 into main Dec 6, 2023
4 checks passed
@Shaptic Shaptic deleted the stable branch December 6, 2023 17:16
Shaptic added a commit to stellar/js-stellar-sdk that referenced this pull request Dec 6, 2023
@Shaptic
Add support for stable Protocol 20 release (both XDR and RPC schemas) (…
f3228f6 
…#886)

* Add all changes matching stellar/js-soroban-client#167
* Refresh yarn.lock
* Fixup Node versions, etc.
* Rename stable package under the `@stellar/` organization (#887)
willemneal pushed a commit to AhaLabs/js-stellar-sdk that referenced this pull request Dec 7, 2023
@Shaptic @willemneal
Add all changes matching stellar/js-soroban-client#167
e91e048
@OKEAMAH OKEAMAH mentioned this pull request May 27, 2024
Open
@kalbroni7 kalbroni7 mentioned this pull request Jul 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreuland sreuland sreuland approved these changes

@stellarsaur stellarsaur Awaiting requested review from stellarsaur

Assignees

@Shaptic Shaptic

Labels
None yet
Projects
Platform Scrum
Status: Done
Milestone
Soroban Stable P20 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shaptic @sreuland