Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coveralls #6

Closed
5 tasks done
thejollyrogers opened this issue Apr 28, 2015 · 4 comments
Closed
5 tasks done

Coveralls #6

thejollyrogers opened this issue Apr 28, 2015 · 4 comments
Assignees

Comments

@thejollyrogers
Copy link
Contributor

  • Integrate Coveralls
  • Publish to npm
  • Travis Build
  • Slack github integration
  • jsdoc generation
@jedmccaleb
Copy link
Contributor

@nullstyle are we going to integrate coveralls?

@nullstyle
Copy link
Contributor

yes, I believe we should. It should be pretty trivial, and anyone of us can do it.

@dydt
Copy link
Contributor

dydt commented Sep 29, 2015

I noticed that we defined gulp submit-coverage in gulpfile.js and have gulp-coveralls in our package.json.

In my branch, I defined gulp-coveralls as part of the instructions in https://www.npmjs.com/package/gulp-coveralls. (https://github.com/stellar/js-stellar-sdk/blob/relative_next/gulpfile.js)

But when I run gulp submit-coverage, nothing happens. I don't have anything that matches "./coverage/**/lcov.info", and I think that's the problem. I noticed that Bartek includes coverage/ in his .gitignore for stellar-wallet (https://github.com/stellar/stellar-wallet/blob/master/.gitignore), so I assume that folder is generated. But I can't find on the internet how to generate it.

@bartekn
Copy link
Contributor

bartekn commented Sep 29, 2015

It's not so trivial because we're using transpiler. We should probably use istanbul+babel-istanbul to check coverage for our ES6 code. @dydt I can work with you on this if you need any help.

@dydt dydt mentioned this issue Sep 29, 2015
@jedmccaleb jedmccaleb reopened this Oct 6, 2015
@jedmccaleb jedmccaleb changed the title REPO TODO Coveralls Oct 6, 2015
@jedmccaleb jedmccaleb assigned bartekn and unassigned dydt Oct 6, 2015
@bartekn bartekn closed this as completed Oct 11, 2015
@bartekn bartekn removed the in orbit label Oct 11, 2015
lhtdeepaktomar pushed a commit to lhtdeepaktomar/js-stellar-sdk that referenced this issue Jun 11, 2021
Added ascii_only option to uglify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants