Wrong type in GetEventsRequest interface

[fazzatti]

WHAT:
RPC calls to getEvents fail with:

[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason 
"#<Object>".] {
  code: 'ERR_UNHANDLED_REJECTION'
}

WHY:
Testing further we could find the root cause for the issue.

js-stellar-sdk/src/soroban/server.ts

Line 38 in dc07e03

startLedger?: number; // either this or cursor

The parameter startLedger under GetEventsRequest is set as a number, while the getEvents expects it to be stringified. See this doc for reference.

Forcing the parameter as a string, fixes the issue and returns the correct output from the RPC server.

[Shaptic]

Two questions:

1. What version are you using?
2. What Soroban RPC version and network are you targeting?

This change actually done intentionally as part of the v11.0.1 release, because the type had changed to a number. You can confirm this in the source code: see get_events.go. That build of the RPC server is currently deployed to futurenet, so if you are targeting testnet in your software, you should be still be using the latest v11 beta of the SDK rather than the stable version (i.e. beta.6).

I believe that documentation needs to be updated, so thank you for noting that!

[fazzatti]

Thank you so much @Shaptic !

Indeed I think you're spot on! I/m on v11.0.1 and targetting testnet!
I'll switch all testing to futurenet to make sure to focus on the correct build of the RPC. What sent me off-guard was that I was testing in parallel using the testnet RPC and the validation cloud API, which are probably both using a similar build because I got similar results.

Sorry for jumping the gun!