Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AccountCallBuilder#address in favor of accountID #48

Merged
merged 2 commits into from
Dec 8, 2015

Conversation

nullstyle
Copy link
Contributor

No description provided.

* Returns information and links relating to a single account.
* The balances section in the returned JSON will also list all the trust lines this account has set up.
*
* @see [Account Details](https://www.stellar.org/developers/horizon/reference/accounts-single.html)
* @param {string} accountId For example: `GDGQVOKHW4VEJRU2TETD6DBRKEO5ERCNF353LW5WBFW3JJWQ2BRQ6KDD`
* @param {id} accountId For example: `GDGQVOKHW4VEJRU2TETD6DBRKEO5ERCNF353LW5WBFW3JJWQ2BRQ6KDD`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This need to be changed to:

@param {string} id 

The format in JSdoc is:

@param {variable type} variable name

@bartekn
Copy link
Contributor

bartekn commented Dec 8, 2015

👍

nullstyle added a commit that referenced this pull request Dec 8, 2015
Deprecate AccountCallBuilder#address in favor of accountID
@nullstyle nullstyle merged commit 7ded89c into master Dec 8, 2015
@abuiles abuiles deleted the deprecate-address branch July 25, 2019 19:46
lhtdeepaktomar pushed a commit to lhtdeepaktomar/js-stellar-sdk that referenced this pull request Jun 11, 2021
Expose source account of operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants