FederationServer #49
FederationServer #49
Conversation
|
For loading parse it and then create and return |
| } | ||
| address = `${address}*${this.domain}`; | ||
| } | ||
| let url = this.serverURL.query(`type=name&q=${address}`); |
There was a problem hiding this comment.
Seems like using the map form of query would be better:
this.serverURL.query({type: "name", q: address});
There was a problem hiding this comment.
https://medialize.github.io/URI.js/docs.html#accessors-search has all the different forms available
There was a problem hiding this comment.
Oh, thanks. I haven't noticed it.
|
+1 |
| * @returns {Promise} | ||
| */ | ||
| static forAddress(address) { | ||
| let [,domain] = address.split('*'); |
There was a problem hiding this comment.
This will behave incorrectly in the presence of 2 asterisks. We should ensure there isn't, returning an error to the user if there is.
|
Other than the bug I pointed out, +1 |
Changes to number arguments
This PR introduces
FederationServerclass that allows sending requests to federation servers.Close #47