Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add information about cdnjs to README #60

Merged
merged 1 commit into from
Feb 17, 2016
Merged

add information about cdnjs to README #60

merged 1 commit into from
Feb 17, 2016

Conversation

irisli
Copy link
Contributor

@irisli irisli commented Feb 16, 2016

@bartekn
Copy link
Contributor

bartekn commented Feb 16, 2016

What do you think about changing:

https://cdnjs.cloudflare.com/ajax/libs/stellar-sdk/0.4.1/stellar-sdk.js

to

https://cdnjs.cloudflare.com/ajax/libs/stellar-sdk/{version}/stellar-sdk.js

Otherwise, I'm afraid it will be copied directly from README without updating to the latest version.

I haven't noticed it in base, we should change it there too.

@irisli
Copy link
Contributor Author

irisli commented Feb 17, 2016

Yeah, it might be a good idea.

bartekn added a commit that referenced this pull request Feb 17, 2016
add information about cdnjs to README
@bartekn bartekn merged commit 41369bc into master Feb 17, 2016
@abuiles abuiles deleted the readme-cdnjs branch July 25, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants