Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade axios library in response to vulnerability (#605) #608

Merged
merged 1 commit into from Jan 15, 2021
Merged

Upgrade axios library in response to vulnerability (#605) #608

merged 1 commit into from Jan 15, 2021

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Jan 12, 2021

Closes #605.

@Shaptic Shaptic self-assigned this Jan 12, 2021
@Shaptic Shaptic requested review from marcelosalloum, kalepail and a team January 12, 2021 22:51
@Shaptic
Copy link
Contributor Author

Shaptic commented Jan 12, 2021

Tiny fix, but tagging all known JS experts just in case heh.

bartekn
bartekn approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@bartekn bartekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I remember that in the past there were some changes in axios API between versions. Can you check if there were none? Would be great to have some integration tests for JS-SDK.

@Shaptic
Copy link
Contributor Author

Shaptic commented Jan 15, 2021

Looked through the CHANGELOG and it doesn't look like anything should break. Agreed re: integration tests, though.

@Shaptic Shaptic merged commit 7644264 into master Jan 15, 2021
@Shaptic Shaptic deleted the upgrade-axios branch January 15, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartekn bartekn bartekn approved these changes

@marcelosalloum marcelosalloum Awaiting requested review from marcelosalloum

@kalepail kalepail Awaiting requested review from kalepail

Assignees

@Shaptic Shaptic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yarn audit failing due to vulnerability in axios 0.19
2 participants
@Shaptic @bartekn