Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Add missing fields to the
LedgerRecord
:successful_transaction_count
andfailed_transaction_count
(#740). Note that this also marks several fields as deprecated because they don't actually exist in the Horizon API response:transaction_count
: superceded by the sum of the aforementioned fieldsbase_fee
: superceded by thebase_fee_in_stroops
fieldbase_reserve
: superceded by thebase_reserve_in_stroops
fieldThese deprecated fields will be removed in the next major version. It's unlikely that this breaking change should affect anyone, as these fields have likely been missing/invalid for some time.
Update
Update a number of dependencies that needed various security updates:
karma
suite of packages has been updated to the latest major version (#743)All of the dependencies in question besides
axios
were developer dependencies, so there never was downstream security impact nor will there be downstream upgrade impact.