Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade major dependencies and configure prettier. #846

Closed
wants to merge 3 commits into from
Closed

Upgrade major dependencies and configure prettier. #846

wants to merge 3 commits into from

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Jul 12, 2023

Turns out, yarn fmt hasn't been affecting TypeScript files.

This upgrades prettier to its latest major version (v3), it moves the configuration to the package.json file (for convenience and uniformity), and it runs yarn fmt on the repo.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 12, 2023
View reviewed changes
test/unit/federation_server_test.js
.withArgs(
sinon.match(
"https://api.stellar.org/federation?type=name&q=bob%2Astellar.org"
'https://api.stellar.org/federation?type=name&q=bob%2Astellar.org'

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High

This regular expression has an unescaped '.' before 'stellar.org/federatio', so it might match more hosts than expected.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bro you're not supposed to be scanning test/

test/unit/server/claimable_balances.js
.withArgs(
sinon.match(
"https://horizon-live.stellar.org:1337/claimable_balances/00000000929b20b72e5890ab51c24f1cc46fa01c4f318d8d33367d24dd614cfdf5491072"
'https://horizon-live.stellar.org:1337/claimable_balances/00000000929b20b72e5890ab51c24f1cc46fa01c4f318d8d33367d24dd614cfdf5491072'

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High

This regular expression has an unescaped '.' before 'stellar.org:1337/claimable_balances/00000000929b20b72e5890ab51c24f1cc46fa01c4f318d8d33367d24dd614cfdf5491072', so it might match more hosts than expected.
test/unit/server/claimable_balances.js
.withArgs(
sinon.match(
"https://horizon-live.stellar.org:1337/claimable_balances?sponsor=GDGQVOKHW4VEJRU2TETD6DBRKEO5ERCNF353LW5WBFW3JJWQ2BRQ6KDD"
'https://horizon-live.stellar.org:1337/claimable_balances?sponsor=GDGQVOKHW4VEJRU2TETD6DBRKEO5ERCNF353LW5WBFW3JJWQ2BRQ6KDD'

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High

This regular expression has an unescaped '.' before 'stellar.org:1337/claimable_balance', so it might match more hosts than expected.
test/unit/server/claimable_balances.js
.withArgs(
sinon.match(
"https://horizon-live.stellar.org:1337/claimable_balances?claimant=GDGQVOKHW4VEJRU2TETD6DBRKEO5ERCNF353LW5WBFW3JJWQ2BRQ6KDD"
'https://horizon-live.stellar.org:1337/claimable_balances?claimant=GDGQVOKHW4VEJRU2TETD6DBRKEO5ERCNF353LW5WBFW3JJWQ2BRQ6KDD'

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High

This regular expression has an unescaped '.' before 'stellar.org:1337/claimable_balance', so it might match more hosts than expected.
test/unit/server/claimable_balances.js
.withArgs(
sinon.match(
"https://horizon-live.stellar.org:1337/claimable_balances?asset=USD%3AGDGQVOKHW4VEJRU2TETD6DBRKEO5ERCNF353LW5WBFW3JJWQ2BRQ6KDD"
'https://horizon-live.stellar.org:1337/claimable_balances?asset=USD%3AGDGQVOKHW4VEJRU2TETD6DBRKEO5ERCNF353LW5WBFW3JJWQ2BRQ6KDD'

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High

This regular expression has an unescaped '.' before 'stellar.org:1337/claimable_balance', so it might match more hosts than expected.
test/unit/liquidity_pool_endpoints_test.js
@@ -3,10 +3,10 @@
return JSON.parse(JSON.stringify(js));
}

const BASE_URL = "https://horizon-live.stellar.org:1337";
const LP_URL = BASE_URL + "/liquidity_pools";
const BASE_URL = 'https://horizon-live.stellar.org:1337';

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High

This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'stellar.org:1337', so it might match more hosts than expected.
test/unit/server/join_test.js
.withArgs(
sinon.match(
"https://horizon-live.stellar.org:1337/operations?join=transactions"
'https://horizon-live.stellar.org:1337/operations?join=transactions'

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High

This regular expression has an unescaped '.' before 'stellar.org:1337/operation', so it might match more hosts than expected.
@Shaptic Shaptic mentioned this pull request Jul 12, 2023
Merged
@Shaptic Shaptic closed this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Shaptic