Fix how failed getTransaction responses are parsed
#872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.05 kB (0%) Total Size: 12.1 MB
|
sreuland
reviewed
Oct 26, 2023
| @@ -307,14 +307,14 @@ export class Server { | |||
| hash: string | |||
| ): Promise<Api.GetTransactionResponse> { | |||
| return this._getTransaction(hash).then((raw) => { | |||
| let successInfo: Omit< | |||
| let foundInfo: Omit< | |||
There was a problem hiding this comment.
any reason why this type is calculated each time in method rather than a non-exported const at top of server.ts or exported as a static Type from api.ts? i.e. TransactionFoundResponse = Omit<...>;
There was a problem hiding this comment.
it won't happen each time, it'll just happen once at "compile time" when the TypeScript is turned into JavaScript. It's not part of the API because this is specifying "the subset of the 'success/failure' schema that does not contain the 'missing' schema," which isn't like a well-defined API concept, it's just useful here because we're trying to create a partially-(but well-)defined subset of an object.
sreuland
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tyvdh reported that the failed case should have way more fields (which is true!) and this should fix that up.
(This also renames
soroban_rpc.tstoapi.tsfor consistency.)