feat(contract-client): match CLI's default timeout #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even 60 seconds, as it was updated to in 2bcbc6a, might be too short if someone is cautiously reviewing the transaction in Freighter, or if they need ot unlock their Ledger and walk through its process. Five minutes is the same as the CLI. Maybe it's a reasonable standard to adopt? This commit also updates utils.ts to use our eslint settings.
chadoh
force-pushed
the
feat/contract-client/default-timeout-300s
branch
from
7a557ac
to
3f13473
Compare
Shaptic
approved these changes
May 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even 60 seconds, as it was updated to in 2bcbc6a, might be too short if someone is cautiously reviewing the transaction in Freighter, or if they need ot unlock their Ledger and walk through its process.
Five minutes is the same as the CLI. Maybe it's a reasonable standard to adopt?