add a from method to ContractClient to instantiate from a contractId #960
Conversation
|
Still marked as draft. Is that intended, @BlaineHeffron? Seems like it's about ready to go! |
See my comment here - #960 (comment) To summarize, I think it makes sense since we are giving a way to create it from a wasm we should also give a way to create it from a wasmHash. This would also make sense in the context of our e2e tests. |
There was a problem hiding this comment.
The RPC work looks good to me, I'll wait for approval from @chadoh / @willemneal on the actual client-side work as I see there's open discussion there before merging!
|
Should be all ready to go now. |
|
Latest commit fixes all of Chad's comments. |
|
Tests are failing |
Looks like that weird spawnSync issue we were seeing before. I added a fallback in case it doesnt work the first time. |
|
ok, I guess I just don't have the correct permissions to get this thing marked as mergeable |
Co-authored-by: George <Shaptic@users.noreply.github.com>
|
I addressed comments from @Shaptic although this now is dependent on stellar/js-stellar-base#744 being merged first. The latest changes remove the external js-xdr dependency and uses the |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@stellar/stellar-base@11.1.0 |
Adds a
frommethod which uses thecontractIdto create an instance of theContractClientby retrieving the wasm from the blockchain and extracting itsContractSpec. I also add afromWasmmethod which bypasses the wasm retrieval portion if you already have the wasm buffer.