Factor Tag::is_object to let Val::is_object delegate to it #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
force-pushed
the
factor-out-duplicate-obj-code-cmp
branch
from
3d2ca44
to
71e951e
Compare
dmkozh
approved these changes
Aug 22, 2023
auto-merge was automatically disabled
August 25, 2023 19:47
Merge queue setting changed
graydon
force-pushed
the
factor-out-duplicate-obj-code-cmp
branch
from
28363fe
to
3a17281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a slight fix following #1012 to avoid the duplicate logic @brson noted in that PR.