Allow Budget::try_from_configs inputs to be less than current xdr-defined count
#1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayz22
requested review from
graydon,
sisuresh,
dmkozh and
a team
as code owners
graydon
approved these changes
Apr 19, 2024
dmkozh
reviewed
Apr 19, 2024
jayz22
force-pushed
the
fix-cost-len
branch
2 times, most recently
from
64e8f1d
to
26d29a1
Compare
…ded value. (stellar#1405)" This reverts commit 27897f6.
undo time_tracker change
This reverts commit c2f2f64.
jayz22
changed the title
Budget::try_from_configs inputs to be less than current xdr-defined count
dmkozh
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves #1388
Why
The current way of constructing the Budget from config enforces the config size must match the protocol-defined count (
ContractCostType::variants().len()). While this ensures the validity of the config entry for the current protocol, it does not take into consideration config from an earlier protocol, with fewer number of cost types.Known limitations
[TODO or N/A]