Remove EnvVal
#608
Merged
Remove EnvVal
#608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisuresh
reviewed
Dec 13, 2022
sisuresh
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
LGTM. @leighmcculloch The main part of this PR was cherry-picked from #600 which you approved. The corresponding sdk change is here - stellar/rs-soroban-sdk#794.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
To rebase and merge the
EnvValremoval part of #600.See #600 (comment) for description
Why
At @graydon 's suggestion to split out the
EnvValremoval part of #600 and merge it first, since it is mostly just clean up and is self-contained.It makes the code base much cleaner.
Known limitations
[TODO or N/A]