Autosave a test snapshot file on every test exit #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-env
that referenced
this pull request
Nov 8, 2023
### What Add fn to find out if Host can be finished. ### Why So that the SDK can ask the Host if it has no more references left and it is able to be finished without calling try_finish which is destructive. I plan to use this in: - stellar/rs-soroban-sdk#1137
…5a47c7b8f91eb3003b4f5bfb9a22777cd6573e4' into i1082
|
Worth calling out there's no way to turn the generation of test snapshots off. I think there's a lot of value of it always being on. If we were going to add a switch for it, it'd be preferable I think to make it opt out rather than opt in. Although, maybe it could slow down fuzzer tests so much that it'd be worth adding a flag for. |
dmkozh
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Autosave a test snapshot file on every test exit.
Why
To encourage the over-time consistency testing of contracts. To provide a mechanism where any developer who commits the generated files can see changes in observable behavior that arises unexpectedly over time.
Close #1082
Merging
To be merged to
mainafter:Snapshot.Adding budget to theSnapshot. (Maybe, seems less clear if should be included.)