Remove {Try}FromVal #815
Closed
Remove {Try}FromVal #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayz22
commented
Jan 4, 2023
| V: IntoVal<Env, RawVal> + TryFromVal<Env, RawVal> + Clone, | ||
| V::Error: Debug, | ||
| K: IntoVal<Env, RawVal> + Clone, | ||
| <RawVal as TryIntoVal<Env, K>>::Error: Debug, |
There was a problem hiding this comment.
I don't like how every T::Error now have to be expressed as
<RawVal as TryIntoVal<Env, K>>::Error, not sure if Rust allows a better way to define this type for an entire struct.
There was a problem hiding this comment.
Need something like the inherent associated type.
jayz22
force-pushed
the
remove-tryfromval
branch
from
f52a0bc
to
058106a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is the sdk side changes necessary for stellar/rs-soroban-env#623 which is a rebased version of stellar/rs-soroban-env#600.
This won't work because it relies on the conversion between a
ResultandRawVal, which is commented out in https://github.com/jayz22/rs-soroban-env/blob/aae7e792518ccd3f086586263263944ccf3d6e4c/soroban-env-common/src/lib.rs#L51-L54 due to the infinite recursion issue.Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]