Define contract spec for Hash; adds instruction for XDR-gen #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayz22
changed the title
dmkozh
approved these changes
Apr 15, 2024
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-env
that referenced
this pull request
Apr 16, 2024
### What Picks up stellar/rs-stellar-xdr#361 ### Why [TODO: Why this change is being made. Include any context required to understand the why.] ### Known limitations [TODO or N/A]
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-sdk
that referenced
this pull request
Apr 23, 2024
### What Add support for secp256r1 signature verification (picking up env changes stellar/rs-soroban-env#1376). And adapts the existing `Crypto` module by split the cryptographic functions into two sets: - `Crypto`: standard, recommended set of cryptographic functions. This includes `secp256k1_recover` and `secp256r1_verify` taking the full `message: Bytes` as input and performs hashing underneath. - `CryptoHazmat`: hazardous material. Contains low-level, unsecure if used incorrectly functions including `secp256k1_recover_prehash` and `secp256r1_verify_prehash`, taking a `message_hash: BytesN<32>` as input. Design rationales were discussed in the env PR (started on stellar/rs-soroban-env#1376 (comment) and onward). XDR changes associated with the new contract spec: stellar/stellar-xdr#182, stellar/stellar-xdr#183 rs-xdr: stellar/rs-stellar-xdr#361 End-to-end with secp256r1 account contract: stellar/rs-soroban-env#1402 ### Why [TODO: Why this change is being made. Include any context required to understand the why.] ### Known limitations [TODO or N/A] --------- Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Picks up:
stellar/stellar-xdr#182
stellar/stellar-xdr#183
Also adds the instruction for how to regenerate from XDR changes.
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]