keytree: add serialization for xpub, xprv #228
Conversation
| let xprv_bytes = xprv.to_bytes(); | ||
|
|
||
| // hardcoded, but happens to be expected_scalar concatenated with expected_dk | ||
| let expected_bytes = [ |
There was a problem hiding this comment.
there's hex crate with hex::encode method so we can write a more readable test (and then copy this over to the spec as Test Vectors):
assert_eq!(hex::encode(&xprv.to_bytes()[..]), "df0da2b88d88de1ad7678d8f012...");There was a problem hiding this comment.
hex is only needed in dev-dependencies in Cargo.toml. So you'd include it only under the mod test { }, not in the top of lib.rs.
There was a problem hiding this comment.
I just tried this out, and it's neat, but I'm not sure it actually produces a more readable test, especially since all the other tests in this package (for creating xprvs and xpubs) use non-hex encoded byte arrays. When I switched over to a hex string, I could no longer eyeball that these were the same.
WDYT?
There was a problem hiding this comment.
i think all have to be hex, across the board. But if it's a PITA to update, we can do that in a separate PR later.
There was a problem hiding this comment.
we'd definitely want that to post the test vectors in the spec in hex. But before that we need to implement derivation for both xpub and xprv.
There was a problem hiding this comment.
I'll do it all in another PR, then. (It's fine to do, I should just change them all together.)
|
looks good, just left a bunch of stylistic rusty nitpicks |
Co-Authored-By: tessr <tess.rinearson@gmail.com>
Co-Authored-By: tessr <tess.rinearson@gmail.com>
Co-Authored-By: tessr <tess.rinearson@gmail.com>
Co-Authored-By: tessr <tess.rinearson@gmail.com>
|
Awesome. I'm going to commit your suggestions, fix any breakages, and then make the bigger changes. Thanks very much! |
Co-Authored-By: tessr <tess.rinearson@gmail.com>
|
Ready for an (I think) final pass! |
|
Ready for another pass! (I will not jinx it this time by suggesting it's final.) |
Addresses #179