Add ledger entry diff to simulateTransaction response #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It adds the following field to `SimulateTransactionResponse`
```
StateDiff []LedgerEntryDiff `json:"stateDiff,omitempty"` // If present, it indicates how the state (ledger entries) will change as a result of the transaction execution.
```
where:
```
// LedgerEntryDiff designates a change in a ledger entry. Before and After cannot be be omitted at the same time.
// If Before is omitted, it constitutes a creation, if After is omitted, it constitutes a delation.
type LedgerEntryDiff struct {
Before string `json:"before,omitempty"` // LedgerEntry XDR in base64
After string `json:"after,omitempty"` // LedgerEntry XDR in base64
}
```
2opremio
force-pushed
the
compute-ledger-entry-diff
branch
from
f7d97ec
to
84ca477
Compare
|
@leighmcculloch PTAL |
2opremio
force-pushed
the
compute-ledger-entry-diff
branch
from
006f1a4
to
29e04e9
Compare
Shaptic
approved these changes
Apr 4, 2024
This was referenced May 6, 2024
This was referenced May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
It adds the following field to
SimulateTransactionResponsewhere:
Why
Closes #11
Known limitations
It can considerably increase the size of simulate transaction responses (particularly for contract uploads, which will contain the full wasm).