Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_version_info endpoint #132

Merged
merged 17 commits into from
May 2, 2024
Merged

Add get_version_info endpoint #132

merged 17 commits into from
May 2, 2024

Conversation

psheth9
Copy link
Contributor

@psheth9 psheth9 commented Apr 10, 2024

Fixes #10

This PR does following things:

  • Call /info endpoint with backoff exp retry to fetch captive core version
  • Reuse getBucketListSizeAndProtocolVersion to fetch protocol version
  • Update MakeFile to populate version, commit_hash and build_time_stamp

get_version_info Response -->

        Version            string `json:"version"`
	CommitHash         string `json:"commit_hash"`
	BuildTimestamp     string `json:"build_time_stamp"`
	CaptiveCoreVersion string `json:"captive_core_version"`
	ProtocolVersion    uint32 `json:"protocol_version"`

Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's still a draft but I was just drivin' by

@psheth9 psheth9 marked this pull request as ready for review April 15, 2024 21:55
@psheth9 psheth9 self-assigned this Apr 15, 2024
@psheth9 psheth9 requested a review from 2opremio April 15, 2024 22:30
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@psheth9 psheth9 merged commit c7b8ddc into main May 2, 2024
20 checks passed
@psheth9 psheth9 deleted the add-getVersion-endpoint branch May 2, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

soroban-rpc: add an endpoint on soroban RPC to self report versions for downstream clients
4 participants