Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate soroban-spec-tools dependency and remove all Soroban CLI references #68

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Incorporate soroban-spec-tools dependency and remove all Soroban CLI references #68

merged 7 commits into from
Feb 20, 2024

Conversation

psheth9
Copy link
Contributor

@psheth9 psheth9 commented Feb 16, 2024 •
edited
Loading

What

  • Add soroban spec tools crate
  • Remove any CLI related code
  • Remove soroban-test crate

Why

We have circular dependency RPC --> cli --> RPC. More context here and here

Known limitations

  • We have not explored all the edge cases yet, still in progress.
  • It might be a good idea to pull out some of the common deps from tools and rpc in order to avoid cyclic mess in future

Soroban-tool PR to link spec-tools: stellar/stellar-cli#1203

@psheth9 psheth9 changed the title [Draft - DO NOT MERGE] Add soroban-spec-tools and remove soroban-tests crate [Draft - DO NOT MERGE] Add soroban-spec-tools in RPC and remove CLI Feb 16, 2024
@Shaptic Shaptic mentioned this pull request Feb 16, 2024
Merged
@psheth9 psheth9 changed the title [Draft - DO NOT MERGE] Add soroban-spec-tools in RPC and remove CLI Add soroban-spec-tools in RPC and remove CLI Feb 16, 2024
@psheth9 psheth9 marked this pull request as ready for review February 20, 2024 18:21
Shaptic
Shaptic reviewed Feb 20, 2024
View reviewed changes
Makefile Show resolved Hide resolved
@Shaptic Shaptic changed the title Add soroban-spec-tools in RPC and remove CLI Incorporate soroban-spec-tools dependency and remove all Soroban CLI references Feb 20, 2024
@Shaptic Shaptic mentioned this pull request Feb 20, 2024
Merged
2 tasks
@psheth9 psheth9 merged commit 1a4f5c8 into main Feb 20, 2024
20 checks passed
@psheth9 psheth9 deleted the add-spec-tools-crate branch February 20, 2024 23:46
sreuland
sreuland reviewed Feb 21, 2024
View reviewed changes
cmd/crates/soroban-spec-tools/Cargo.toml
[package]
name = "soroban-spec-tools"
description = "Tools for using a contract's XDR spec"
homepage = "https://github.com/stellar/soroban-tools"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these refs to soroban-tools be changed soroban-rpc now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sreuland Yes already on it :)

@mollykarcher mollykarcher mentioned this pull request Feb 26, 2024
Closed
@psheth9 psheth9 mentioned this pull request Mar 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreuland sreuland sreuland left review comments

@Shaptic Shaptic Shaptic approved these changes

@2opremio 2opremio Awaiting requested review from 2opremio

@tamirms tamirms Awaiting requested review from tamirms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@psheth9 @Shaptic @sreuland