Upgrade wasm-opt to 0.111.0 #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsachiherman
reviewed
Jan 3, 2023
There was a problem hiding this comment.
I'm not opposing to this one, but wondering if we have a similar dependency that might use a different version. @leighmcculloch ?
leighmcculloch
approved these changes
Jan 4, 2023
@tsachiherman There shouldn't be a consistency issue with upgrading here. I don't think we use wasm-opt elsewhere. |
chadoh
added a commit
to AhaLabs/stellar-cli
that referenced
this pull request
Jan 9, 2023
* main: Bump version to 0.4.0 (stellar#337) soroban-cli: update rust dependencies (stellar#334) Disable optional features in wasm-opt (stellar#335) update go monorepo deps (stellar#326) Upgrade wasm-opt to 0.111.0 (stellar#331) fix per linter's feedback. (stellar#327)
chadoh
added a commit
to AhaLabs/stellar-cli
that referenced
this pull request
Jan 12, 2023
* main: feat(CI): add git hooks and improve tests to calculate file hash first (stellar#321) feat: reorganize CLI under new subcommands (stellar#319) soroban-rpc: Add tx xdr, meta, and result xdr to getTransactionStatus (stellar#317) Simplify how topic matching works in RPC & CLI (stellar#324) integration testing: fix "unable to find commit hash" during tests (stellar#338) Bump version to 0.4.0 (stellar#337) soroban-cli: update rust dependencies (stellar#334) Disable optional features in wasm-opt (stellar#335) update go monorepo deps (stellar#326) Upgrade wasm-opt to 0.111.0 (stellar#331) fix per linter's feedback. (stellar#327)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This upgrades binaryen to version 111.
Binaryen (and wasm-opt) now enables the
SignExtandMutableGlobalsfeatures by default, which are also enabled in the LLVM backend. In the future Binaryen will align its default feature selection with the LLVM backend.This is probably is ok for soroban - wasmi supports both these.
This also points to potential future optimizations by explicitly turning on more features that wasmi supports but that aren't enabled in wasm-opt by default.
The changelog for 0.111.0.
Why
Just upgrading deps.
Known limitations
N/A