Skip to content

Commit

Permalink
Windows: do not inherit all handles
Browse files Browse the repository at this point in the history 
Previous fix for this 13e9306 missed that we should also disable global inheritance (and only use the white list)
  • Loading branch information
@MonsieurNicolas
MonsieurNicolas committed Aug 27, 2019
1 parent e830259 commit 2aac760
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/process/ProcessManagerImpl.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ ProcessExitEvent::Impl::run()
cmd, // Command line
nullptr, // Process handle not inheritable
nullptr, // Thread handle not inheritable
TRUE, // Inherit file handles
FALSE, // only inherit handles from `iH`
CREATE_NEW_PROCESS_GROUP | // Create a new process group
EXTENDED_STARTUPINFO_PRESENT, // use STARTUPINFOEX
nullptr, // Use parent's environment block
Expand Down

5 comments on commit 2aac760

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from marta-lokhova
at MonsieurNicolas@2aac760

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging MonsieurNicolas/stellar-core/windowsFixesHandlesBuild = 2aac760 into auto

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MonsieurNicolas/stellar-core/windowsFixesHandlesBuild = 2aac760 merged ok, testing candidate = 326d719

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/577615912?utm_source=github_status&utm_medium=notification

@latobarita
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 326d719

Please sign in to comment.