Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stellar-core new autoconfig code can't handle example config (Version 11.2.0) #2209

Closed
graydon opened this issue Jul 29, 2019 · 0 comments · Fixed by #2233
Closed

Stellar-core new autoconfig code can't handle example config (Version 11.2.0) #2209

graydon opened this issue Jul 29, 2019 · 0 comments · Fixed by #2233
Assignees
Labels

Comments

@graydon
Copy link
Contributor

graydon commented Jul 29, 2019

In #2125 a new config was added docs/stellar-core_example_validators.cfg which, if you run stellar-core with it, fails assertion isQuorumSetSane.

This is because we defined quorum sets as sane only if they're 3 nesting levels or shallower, and the new auto-config code groups nodes by homeDomain before putting them into nesting levels. This makes for a 4-level nesting overall, not 3.

A trivial fix for this is to change the test in QuorumSanityChecker::checkSanity from depth > 2 to depth > 3 but I'm not sure if that's actually the semantics we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants