Fix quorum checks (runtime and startup) for automatically generated quorums #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r+ 3efab57 |
MonsieurNicolas
force-pushed
the
fixQuorumChecksStartupAndAutoExamples
branch
from
3efab57
to
aa45d9e
Compare
|
forgot to update some tests |
|
r+ aa45d9e |
latobarita
added a commit
that referenced
this pull request
Aug 16, 2019
…ndAutoExamples Fix quorum checks (runtime and startup) for automatically generated quorums Reviewed-by: MonsieurNicolas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2209
Turns out that the validity check was not in the right place (too late), so tests never caught this.
We do want to increase the limit here as to be able to mix all quality levels.