Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Scp timeout short circuit v blocking fix #1935
This PR supersedes #1786
It adds a few comments and tests to cover updating values of
While working on this, I noticed an actual bug, fixed in the "short-circuiting logic..." commit:
The previous code was bailing out if there were any validator on a smaller counter than the current counter.
graydon left a comment
So I think I agree with @jonjove that the effect of this change is (semantically) just to change the early break in the second loop of
In the process of deciding it was correct, I refactored and commented it a fair bit; if you'd like to pull in that change too, I've posted it here:
If you like I can file it as a subsequent cleanup PR later.
added a commit
this pull request
Feb 5, 2019
Feb 5, 2019
1 check passed
thanks Pada tanggal Rab, 6 Feb 2019 pukul 05.25 Latobarita < email@example.com> menulis:…
Merged #1935 <#1935> into master. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1935 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AtBCEmlZj3nNcr1JeI0P9jpLDj44K9A1ks5vKgTagaJpZM4aZUl4> .