Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change offerID to int64_t #2044

Merged
merged 1 commit into from Apr 16, 2019
Merged

Conversation

marta-lokhova
Copy link
Contributor

@marta-lokhova marta-lokhova commented Apr 10, 2019

Update offerID in XDR and the codebase to be signed 64-bit ints. Resolves #1960

@MonsieurNicolas MonsieurNicolas added this to To do in v11.0.0 via automation Apr 10, 2019
src/invariant/LedgerEntryIsValid.cpp Outdated Show resolved Hide resolved
src/ledger/LedgerTxnOfferSQL.cpp Outdated Show resolved Hide resolved
src/xdr/Stellar-transaction.x Outdated Show resolved Hide resolved
@MonsieurNicolas MonsieurNicolas moved this from To do to In progress in v11.0.0 Apr 10, 2019
src/test/TestMarket.h Show resolved Hide resolved
src/transactions/test/OfferTests.cpp Outdated Show resolved Hide resolved
@marta-lokhova marta-lokhova changed the title Change offerID/memo ID to int64_t Change offerID to int64_t Apr 16, 2019
@marta-lokhova
Copy link
Contributor Author

r+ 25b0559

latobarita added a commit that referenced this pull request Apr 16, 2019
Change offerID to int64_t

Reviewed-by: marta-lokhova
@latobarita latobarita merged commit 25b0559 into stellar:master Apr 16, 2019
v11.0.0 automation moved this from In progress to Done Apr 16, 2019
@marta-lokhova marta-lokhova deleted the xdr_update branch April 23, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v11.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

audit unsigned types in xdr
5 participants