Remove crypto dependency from SCP #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r+ 842024e822eed1333d04dd70c5af89ebf98471be |
MonsieurNicolas
force-pushed
the
scpMessageValid
branch
from
842024e
to
aaac85c
Compare
|
r+ aaac85c01de6d800c240ad8f31c97c236dcbdb14 |
MonsieurNicolas
force-pushed
the
scpMessageValid
branch
from
aaac85c
to
dba1328
Compare
MonsieurNicolas
force-pushed
the
scpMessageValid
branch
from
dba1328
to
cab5be0
Compare
|
r+ cab5be0 |
latobarita
added a commit
that referenced
this pull request
Apr 12, 2019
Remove crypto dependency from SCP Reviewed-by: MonsieurNicolas
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves crypto responsibilities from SCP into the application.
This change:
allows to not sign messages that don't get sent (performance)(turns out we cannot do this, so I removed this commit)