Rebuild db and replay buckets with differing logic #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonsieurNicolas
requested changes
May 3, 2019
|
This PR needs to be revived @graydon |
graydon
force-pushed
the
rebuild-db-and-replay-buckets-with-differing-logic
branch
from
f5dcb57
to
f6d00de
Compare
|
@MonsieurNicolas fixed up / rebased. |
|
Looks good. We'll merge as soon as |
|
r+ f6d00de |
latobarita
added a commit
that referenced
this pull request
Jul 1, 2019
…ith-differing-logic Rebuild db and replay buckets with differing logic Reviewed-by: MonsieurNicolas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This includes 3 pieces from recent bucket work. I can separate them out into separate PRs if you like, though IMO they are relatives (they all got written while I was running tests of the new INITENTRY code doing replay on old ledger history).
Checklist
clang-formatv5.0.0 (viamake formator the Visual Studio extension)