Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run all tests on travis #2180

Merged
merged 7 commits into from
Aug 13, 2019
Merged

Do not run all tests on travis #2180

merged 7 commits into from
Aug 13, 2019

Conversation

vogel
Copy link
Contributor

@vogel vogel commented Jul 3, 2019

Description

Partially resolves #2155

Move several history test to new [acceptance] category that is not run by default. Those tests are responsible for majority of [history] test time but provide less than 20% of code coverage.

Additionally, all [history] tests categories were revisited for simplification. For example, categories used for only one test were removed, as catch allows to chose tests both by category and full name.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v5.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@MonsieurNicolas MonsieurNicolas added this to In progress in v11.3.0 via automation Jul 4, 2019
Copy link
Contributor

@MonsieurNicolas MonsieurNicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor updates needed

src/test/selftest-parallel Show resolved Hide resolved
@MonsieurNicolas MonsieurNicolas removed this from In progress in v11.3.0 Aug 7, 2019
@MonsieurNicolas MonsieurNicolas added this to In progress in v11.4.0 via automation Aug 7, 2019
@MonsieurNicolas
Copy link
Contributor

@vogel needs to be rebased and I'll merge

Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
…avis

Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
@vogel
Copy link
Contributor Author

vogel commented Aug 13, 2019

Rebased

@MonsieurNicolas
Copy link
Contributor

r+ 8cd071b

latobarita added a commit that referenced this pull request Aug 13, 2019
Do not run all tests on travis

Reviewed-by: MonsieurNicolas
@latobarita latobarita merged commit 8cd071b into stellar:master Aug 13, 2019
v11.4.0 automation moved this from In progress to Done Aug 13, 2019
MonsieurNicolas added a commit to MonsieurNicolas/stellar-core that referenced this pull request Aug 14, 2019
…ts-on-travis"

This reverts commit d0b9cd3, reversing
changes made to 46d5df0.
@vogel vogel deleted the do-not-run-all-tests-on-travis branch September 11, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v11.4.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants