Allow setting upgrades at a ledger number #2207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is cool! I somehow thought that upgrade targets were surfaced in the XDR and this was going to take a protocol change, but it looks much easier! Hurray! |
graydon
requested changes
Jul 25, 2019
There was a problem hiding this comment.
Mostly looks good! Except for exclusivity-of-state issue, which .. if you want to defer / are in a rush, I can accept as-is, but I'd prefer to see it made robust against that class of misuse (especially since it means potentially doing an upgrade at the wrong time in the field: serious symptom if it ever happens!)
marta-lokhova
force-pushed
the
allow_set_upgrades_at_ledger
branch
from
2456490
to
b0ec2fb
Compare
vogel
reviewed
Aug 14, 2019
|
Not required for protocol 12 anymore, but we should revive this PR if we ever want to have this functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures we can upgrade at a particular ledger number. Specifically, it is useful in the context of bucketlist-related upgrades, as we can select the ledger, that is right after any large merge spills, to avoid stalling the network.