Refactor publish-related work to avoid races #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonsieurNicolas
requested changes
Aug 9, 2019
|
Ok, comments should be addressed now: currently all changes are in a separate commit, I'll squash and rebase when we're ready to land. |
MonsieurNicolas
requested changes
Aug 13, 2019
vogel
reviewed
Aug 14, 2019
…ead query explicitly when needed
marta-lokhova
force-pushed
the
avoid_gzip_race_on_publish
branch
from
c930863
to
c056dbf
Compare
|
Just one pending question @marta-lokhova |
|
r+ c056dbf |
latobarita
added a commit
that referenced
this pull request
Aug 15, 2019
Refactor publish-related work to avoid races Reviewed-by: MonsieurNicolas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2190