Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail loadgen when load is too high, remove Simulation dependency #2220

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

marta-lokhova
Copy link
Contributor

Resolves #2199

Copy link
Contributor

@MonsieurNicolas MonsieurNicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Some minor questions/suggestions

src/simulation/LoadGenerator.cpp Show resolved Hide resolved
src/simulation/LoadGenerator.cpp Outdated Show resolved Hide resolved
src/simulation/LoadGenerator.cpp Show resolved Hide resolved
src/simulation/LoadGenerator.h Outdated Show resolved Hide resolved
@marta-lokhova
Copy link
Contributor Author

Ok, comments should be addressed now (and changes squashed)

@MonsieurNicolas
Copy link
Contributor

r+ dc7248e

latobarita added a commit that referenced this pull request Aug 14, 2019
Fail loadgen when load is too high, remove Simulation dependency

Reviewed-by: MonsieurNicolas
@latobarita latobarita merged commit dc7248e into stellar:master Aug 14, 2019
v11.4.0 automation moved this from In progress to Done Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v11.4.0
  
Done
Development

Successfully merging this pull request may close these issues.

Loadgen not working as expected
3 participants